This repository was archived by the owner on Oct 27, 2020. It is now read-only.
perf: throw early if file doesn't exists #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #5 +/- ## ======================================= - Coverage 15.47% 0% -15.48% ======================================= Files 2 2 Lines 84 80 -4 Branches 13 12 -1 ======================================= - Hits 13 0 -13 + Misses 71 68 -3 - Partials 0 12 +12
Continue to review full report at Codecov.
|
Jessidhia approved these changes Jun 8, 2017
Jessidhia left a comment
Jessidhia left a comment There was a problem hiding this comment.
Avoids a stat(2) call, SGTM.
Almost all of the diff is just a reindent.
michael-ciniawsky changed the title 
michael-ciniawsky approved these changes Jun 8, 2017
joshwiens approved these changes Jun 8, 2017
bebraw approved these changes Jun 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Why:
fs.existsis deprecated.fs.readFilealso throw error if the file is not readable or not exist. It is reduce fs call.