Skip to content

feat: transaction polling task #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

feat: transaction polling task #797

merged 1 commit into from
Mar 13, 2023

Conversation

JeneaVranceanu
Copy link
Collaborator

Summary of Changes

Await for a transaction until it's complete (successfully or not.)

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.
@JeneaVranceanu JeneaVranceanu added the enhancement New feature or request label Mar 10, 2023
@JeneaVranceanu JeneaVranceanu self-assigned this Mar 10, 2023
janndriessen
janndriessen approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@janndriessen janndriessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Feel free to merge the branch of #798 in here if the remote test makes sense as well.
@JeneaVranceanu JeneaVranceanu merged commit f909499 into web3swift-team:develop Mar 13, 2023
@JeneaVranceanu JeneaVranceanu deleted the feat/transaction-awaiting branch March 13, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants
@JeneaVranceanu @janndriessen