Skip to content

chore: remove   from PR template #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2022
Merged

chore: remove   from PR template #706

merged 1 commit into from
Dec 12, 2022

Conversation

JeneaVranceanu
Copy link
Collaborator

Summary of Changes

Just a suggestion (we can close this PR if you won't approve it).
IMHO, it looks better without extra space in the description.
Before:

Screenshot 2022-12-08 at 19 11 55

After:

Screenshot 2022-12-08 at 19 12 12

Test Data or Screenshots

 

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.
@JeneaVranceanu JeneaVranceanu self-assigned this Dec 8, 2022
janndriessen
janndriessen approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@janndriessen janndriessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hard opinion this. Feel free to change it.
@yaroslavyaroslav yaroslavyaroslav merged commit ed2dc96 into develop Dec 12, 2022
@yaroslavyaroslav yaroslavyaroslav deleted the chore/pr-template-patch-1 branch December 12, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@JeneaVranceanu @janndriessen @yaroslavyaroslav