Skip to content

Conversation

JeneaVranceanu
Copy link
Collaborator

@JeneaVranceanu JeneaVranceanu commented Dec 8, 2022

Summary of Changes

Only available for review after #704 is merged as they share 1 commit.
Just cleaning some code. Spacing, indents, redundant lines of code like let contract = self.contract.

What has been done:

  • removed parameters: [AnyObject](), extraData: Data() from all createReadOperation calls as these are default values;
  • added spacing between {} and the code inside;
  • removed redundant self. uses;
  • removed let contract = self.contract lines;
  • and instead of
let tx = contract.createWriteOperation("setAllowance", parameters: [to, value] as [AnyObject] )! return tx 

just returning a result of contract.create....

 

Test Data or Screenshots

 

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.
@yaroslavyaroslav yaroslavyaroslav merged commit 0070078 into web3swift-team:develop Dec 12, 2022
@JeneaVranceanu JeneaVranceanu deleted the chore/tokens-cleanup branch December 12, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants