ERC20 read properties issue #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JeneaVranceanu requested changes Nov 21, 2022
| @janndriessen All the comments I've left in the |
janndriessen commented Nov 22, 2022
…provider private set
JeneaVranceanu requested changes Nov 22, 2022
JeneaVranceanu approved these changes Nov 22, 2022
yaroslavyaroslav approved these changes Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The PR was triggered by the issue #676. The function works but it's inaccessible as described. Now some refactoring and clean up was included.
ERC20BasePropertiesto separate fileERC20BasePropertiesProviderwhich now handles fetching the data