Skip to content

[WIP] fix: EIP681 parsing query parameters with extra whitespace characters #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[WIP] fix: EIP681 parsing query parameters with extra whitespace characters #611

wants to merge 6 commits into from

Conversation

@JeneaVranceanu
Copy link
Collaborator

@JeneaVranceanu JeneaVranceanu commented Aug 25, 2022 •
edited
Loading

What was introduced?

  1. Corrected parsing of query parameters of EIP681 URL if that parameter is an array and contains whitespace characters between elements, e.g. ethereum:0x5ffc...4cc4/functionName?bytes2[]=[0xFFFF, 0x0551 , 0x2200,0x1212]. White space between items and separators resulted in incorrect decoding.
  2. Added encoding of value, gasLimit, gasPrice into the EIP681 when calling makeEIP681Link() -> String?.
    Example: ethereum:0x5ffc...4cc4?value=77445123&gasLimit=1234&gasPrice=789456
@yaroslavyaroslav
Copy link
Collaborator

yaroslavyaroslav commented Sep 20, 2022

@JeneaVranceanu Is this PR ready to be merged?
@yaroslavyaroslav yaroslavyaroslav deleted the branch web3swift-team:unstable September 27, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@JeneaVranceanu @yaroslavyaroslav