chore: EthereumBloomFilter improvement #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…a bit better, some refactoring with at least 10% improvement in calculation of a filter.
JeneaVranceanu commented Aug 11, 2022
| static func bloom9(_ data: Data) -> BigUInt { | ||
| // TODO: update to match this implementation https://manbytesgnu.com/eth-log-bloom.html | ||
| // TODO: it will increase performance. | ||
| let b = data.sha3(.keccak256) |
There was a problem hiding this comment.
A few comments left here with a link to the implementation of a bloom filter that should have better performance.
I'll open an issue so that we keep a record of that.
| Thank you, I'll merge it soon, after meeting my huge PR that merges all different transaction types into one. |
| @JeneaVranceanu Sorry I've broke your PR, could you please update it? |
@yaroslavyaroslav Sure, no worries! |
| @yaroslavyaroslav Conflicts fixed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added docs, structured code a bit better, some refactoring with at least 10% improvement in the calculation of a filter.
This PR contains refactoring of
bloom9function.The rest is just renaming a file, reordering of functions, documentation and one performance test.