Skip to content

Conversation

@SyMind
Copy link
Member

@SyMind SyMind commented Oct 20, 2025

This PR adds benchmarking for source map operations including parsing from JSON and cloning operations. It extracts source map-related constants and functions into a dedicated bench module to improve code organization.

Creates a new bench_source_map.rs module with benchmarks for source map parsing and cloning
Moves source map constants from main bench file to the new module
Adds the new benchmarks to the criterion benchmark group

Copilot AI review requested due to automatic review settings October 20, 2025 09:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds benchmarking for source map operations including parsing from JSON and cloning operations. It extracts source map-related constants and functions into a dedicated bench module to improve code organization.

  • Creates a new bench_source_map.rs module with benchmarks for source map parsing and cloning
  • Moves source map constants from main bench file to the new module
  • Adds the new benchmarks to the criterion benchmark group

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
benches/bench_source_map.rs New module containing source map benchmarks for parsing and cloning operations
benches/bench.rs Integrates new source map benchmarks and removes moved constants

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SyMind SyMind force-pushed the bench-raw-source-map branch from b3fe415 to a77da66 Compare October 20, 2025 09:13
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #176 will not alter performance

Comparing SyMind:bench-raw-source-map (a77da66) with main (e1bd85d)

Summary

✅ 7 untouched
🆕 3 new

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 parse_source_map_from_json N/A 44.3 ms N/A
🆕 source_map_clone N/A 1.4 µs N/A
🆕 stringify_source_map_to_json N/A 16.7 ms N/A
@SyMind SyMind enabled auto-merge (squash) October 20, 2025 11:04
@SyMind SyMind merged commit d86a37a into web-infra-dev:main Oct 20, 2025
7 checks passed
@SyMind SyMind deleted the bench-raw-source-map branch October 20, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants