refactor: improve compiler hook handling and type safety #6570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of chenjiahan November 13, 2025 07:09
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors compiler hook handling to improve type safety by making previously optional parameters required and renaming a hook for consistency.
Key changes:
- Made
beforeCompileandbeforeEnvironmentCompilehook parameters required instead of optional - Renamed
beforeEnvironmentCompilertobeforeEnvironmentCompilethroughout the codebase for naming consistency - Removed optional chaining for
bundlerConfigsparameters that are now guaranteed to be defined
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/provider/build.ts | Added explicit bundlerConfigs assignment when using a custom compiler to support the new required parameter type |
| packages/core/src/hooks.ts | Refactored hook handling: renamed beforeEnvironmentCompiler parameter for consistency, removed optional chaining for required parameters, improved variable naming (p → promise, extracted runHook variable), and removed unnecessary biome-ignore comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Improve compiler hook handling and type safety:
beforeCompileandbeforeEnvironmentCompilerequiredbundlerConfigsbeforeEnvironmentCompilertobeforeEnvironmentCompilefor consistencyChecklist