Skip to content

Conversation

@Mikemosca
Copy link
Contributor

Add integration test workflow

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #123 (538cd74) into master (eabf47a) will not change coverage.
The diff coverage is n/a.

❗ Current head 538cd74 differs from pull request most recent head 2b09d6f. Consider uploading reports for the commit 2b09d6f to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@ ## master #123 +/- ## ======================================= Coverage 97.94% 97.94% ======================================= Files 19 19 Lines 3755 3755 ======================================= Hits 3678 3678 Misses 77 77 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabf47a...2b09d6f. Read the comment docs.

Copy link

@jeff-arn jeff-arn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At first I thought we had a bunch of duplicate names for the secrets, but I see the naming scheme now. It feels a little strange to have all the secret values be _APIKEY even when they aren't API keys though. We might consider changing the secret names to match what they are.

@Mikemosca
Copy link
Contributor Author

LGTM. At first I thought we had a bunch of duplicate names for the secrets, but I see the naming scheme now. It feels a little strange to have all the secret values be _APIKEY even when they aren't API keys though. We might consider changing the secret names to match what they are.

Yea, I agree. I am going to do that. Thanks

@Mikemosca Mikemosca merged commit cae45af into master Oct 28, 2021
@watson-github-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants