Add basic support for passing command-line arguments to commands #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nacx changed the title 
Owner
| Thanks for taking the time to add this feature (and tests!), it's really needed. After some thought I decided that I only have one change request: instead of a csv list of options it would be more natural to allow users to add positional arguments as they would for a bash script... so instead of What are your thoughts? |
Contributor Author
| Yes, sounds better. I'll change it that way 😀 |
Contributor Author
| Done! |
Owner
| Looks great, thanks again! |
| Can this be added to the README? I didn't know that this was a thing till I thought to make a feature request, and was searching through merged PR's. |
Owner
| @RyoshiKayo good point! Added in d4ddaa0 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.