Skip to content

Conversation

@marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Oct 17, 2025

  • Added monitoring step in 'apply orientation lock' algorithm
  • Ensures pre-lock conditions (fullscreen, installed app status) are continuously checked
  • Automatically runs 'fully unlock' steps when conditions no longer hold
  • Provides general catch-all beyond existing Fullscreen API integration
  • Improves user experience and security by preventing stale orientation locks

Closes #243

The following tasks have been completed:

  • Modified Web platform tests (link to pull request)

Implementation commitment:


Preview | Diff

- Added monitoring step in 'apply orientation lock' algorithm - Ensures pre-lock conditions (fullscreen, installed app status) are continuously checked - Automatically runs 'fully unlock' steps when conditions no longer hold - Provides general catch-all beyond existing Fullscreen API integration - Improves user experience and security by preventing stale orientation locks Fixes #243
@marcoscaceres marcoscaceres changed the title Fix Issue #243: Add continuous monitoring for pre-lock conditions Add continuous monitoring for pre-lock conditions Oct 17, 2025
@marcoscaceres marcoscaceres requested a review from Copilot October 17, 2025 06:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a continuous monitoring step to the “apply orientation lock” algorithm so that pre-lock conditions are re-checked and the orientation lock is fully unlocked when those conditions cease to hold. This aims to prevent stale orientation locks outside of the Fullscreen API hooks.

  • Add a monitoring step to run “fully unlock” when pre-lock conditions no longer hold
  • Integrate the step to run in parallel with the algorithm’s processing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants