Skip to content

make menuitemradio subclass menuitem, require aria-checked #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

make menuitemradio subclass menuitem, require aria-checked #1354

merged 1 commit into from
Dec 15, 2020

Conversation

@carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Nov 20, 2020 •
edited by pr-preview bot
Loading

Closes #1347.

This PR:

  • changes the superclass of menuitemradio to be menuitem (instead of menuitemcheckbox)
  • makes aria-checked a required attribute of menuitemradio (was previously inherited from menuitemcheckbox)

Also, because menuitem superclass is now obviously a Related concept:

  • changed menuitem to menuitemcheckbox under the Related concepts for menuitemradio
  • changed menuitem to menuitemradio under the Related concepts for menuitemcheckbox

@WilcoFiers - would be great if you have a chance to review this. :)

Preview | Diff
@carmacleod carmacleod requested a review from jnurthen November 20, 2020 16:00
@JAWS-test
Copy link
Contributor

JAWS-test commented Nov 22, 2020

The class diagram should be updated too because it is linked at 5.3 Categorization of Roles
@jnurthen
Copy link
Member

jnurthen commented Nov 22, 2020

@JAWS-test The class diagram is no longer maintained. If you follow the link it states this.
@JAWS-test
Copy link
Contributor

JAWS-test commented Nov 24, 2020

I thought there will be a new one: #1222
@carmacleod
Copy link
Contributor Author

carmacleod commented Nov 24, 2020 •
edited
Loading

@jnurthen I think @pkra's Tree diagram from #1222 is quite nice, and we should link to it for ARIA 1.3.
(Thanks for the pointer, @JAWS-test).

At a minimum, we could update it and put it at a 1.3 variant of: https://www.w3.org/WAI/ARIA/1.2/class-diagram/
@carmacleod carmacleod mentioned this pull request Dec 8, 2020
Open
@carmacleod carmacleod requested a review from pkra December 9, 2020 14:55
@jnurthen jnurthen requested a review from sinabahram December 10, 2020 18:50
@jnurthen jnurthen merged commit 257b0e1 into master Dec 15, 2020
@jnurthen jnurthen deleted the car/issue1347 branch March 3, 2021 16:57
@pkra pkra added this to the ARIA 1.3 milestone Jan 12, 2022
@pkra pkra mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@carmacleod @JAWS-test @jnurthen @pkra @sinabahram