Resolve the skipWaiting() promise after activation completes. #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The Activate algorithm's final step was to run Update Worker State to make the worker `activated`. However Update Worker State just queues a task to do so. So the task would run after skipWaiting() resolved its promise, which wasn't the intent of the spec. Fixes w3c#1187.
Member Author
| @jungkees @wanderview @jakearchibald please take a look |
mfalken added a commit to mfalken/web-platform-tests that referenced this pull request Jun 19, 2018
Member Author
| WPT change at web-platform-tests/wpt#11566 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Activate algorithm's final step was to run Update Worker State
to make the worker
activated. However Update Worker Statejust queues a task to do so. So the task would run after
skipWaiting() resolved its promise, which wasn't the intent of
the spec.
Fixes #1187.
Preview | Diff