Skip to content

fix: no special character replacement in fileName #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2021
Merged

fix: no special character replacement in fileName #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
883dd8a
fix: no special character replacement in fileName
lucacasonato Apr 26, 2021
d2d6200
simplify
lucacasonato Apr 27, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,9 +689,7 @@ user agents must run the following steps:
and {{File/File(fileBits, fileName, options)/options}}.


2. Let |n| be a new string of the same size as the {{fileName}} argument to the constructor.
Copy every character from {{fileName}} to |n|,
replacing any "/" character (U+002F SOLIDUS) with a ":" (U+003A COLON).
2. Let |n| be the {{fileName}} argument to the constructor.

Note: Underlying OS filesystems use differing conventions for file name;
with constructed files, mandating UTF-16 lessens ambiquity when file names are converted to <a>byte</a> sequences.
Expand Down