Fix array rebind #22
Merged
Fix array rebind #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
posva force-pushed the fix-array-rebind branch 3 times, most recently from 7315c94 to 7fd4b37 Compare 
posva force-pushed the fix-array-rebind branch from bd4fc8d to 14bc018 Compare posva added a commit that referenced this pull request Jul 10, 2018
Closes #22 Signed-off-by: Eduardo San Martin Morote <posva13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This should fix #19 and close #20
Conditionally defining the property as reactive should be a better choice than deleting the binding
I'm wondering if we should automatically unbind when binding if a binding already exist. It'll prevent the user from calling unbind each time he wants to bind a new ref