Skip to content

Conversation

@dsseng
Copy link

@dsseng dsseng commented Feb 24, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Closes #9454.

Co-Authored-By: sh7dm <sh7dm@outlook.com>
@dsseng dsseng changed the title feat(lifecycle): add beforeDeactivated hook (implement #9454) feat(lifecycle): add beforeDeactivate hook (implement #9454) Feb 24, 2019
@flozero
Copy link

flozero commented Feb 24, 2019

As there is beforeDestroy hook it seem's interesting to add id but do you have any usecase for it ? I see about the #9454. Maybe it need more informations / docs update about more use case

@danyadev
Copy link

danyadev commented May 3, 2019

@Justineo Done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants