fix #9284: Retrigger propsData getter before current watcher teardown #9327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
posva reviewed Jan 16, 2019
src/core/instance/lifecycle.js Outdated
| vm._isBeingDestroyed = false | ||
| } | ||
| | ||
| let releaseStack = new WeakMap() |
There was a problem hiding this comment.
we cannot use a weakmap as it would break support for IE
There was a problem hiding this comment.
Thanks for your code review, I had coding WeakMap in another way to support lower version IE.
| Hey, I appreciate that you created a custom Map to handle that but that would be too much. I didn't review the memory leak nor the PR (completely yet). I don't want you to waste more time on partial reviews so I'll do a full review when I can :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
You can test in this case https://github.com/MR-fisher/vue-memory-leak-case.