Skip to content

Conversation

@Zarad1993
Copy link
Contributor

@Zarad1993 Zarad1993 commented Dec 22, 2018

Closes #9224

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Error Handling

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Proof

Before

screen shot 2018-12-22 at 1 36 46 pm

After

screen shot 2018-12-22 at 1 37 43 pm

@Zarad1993
Copy link
Contributor Author

@posva - Do you think this needs any changes or do you think it might be promoted to code review?

@Zarad1993
Copy link
Contributor Author

@posva - Just following up on this. A friendly reminder to have a peak at it when possible 😄

Copy link
Contributor

@sid-maddy sid-maddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor changes. @posva, please have a look at it as well.

@posva posva changed the title Fix #9224 Warn type when not a constructor feat(warn): better message with no constructors props Mar 30, 2021
Zarad1993 and others added 2 commits March 30, 2021 11:31
Co-authored-by: Siddhesh Mhadnak <siddhesh.mhadnak@outlook.com>
@posva posva changed the title feat(warn): better message with no constructors props fix(warn): better message with no constructors props Mar 30, 2021
@posva posva merged commit 6940131 into vuejs:dev Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants