Skip to content

Conversation

@katallaxie
Copy link

@katallaxie katallaxie commented May 29, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

This change allows to overwrite the defaults (e.g. isUnaryTag) for the vue-server-renderer. Which should allow to build some more advanced features (e.g. allow to render RSS). Also, it changes the initialization of the SSR renderFunction as it passes along the isUnaryTag to the creation of the compileFunctions.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:

@katallaxie katallaxie changed the title chore: allow overwrite server renderer defaults fix(renderer): allow overwrite server renderer defaults Jun 10, 2018
) {
const options = baseOptions
options.isUnaryTag = isUnaryTag || baseOptions.isUnaryTag
compile = createCompiler(options)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause each createRenderer to overwrite the compiler from the previous call. (i.e. creating a second renderer with different options will affect a previously created renderer)

@yyx990803
Copy link
Member

I know this is a late review, but I would like to see a more concrete use case example - e.g. how the post-patch API can be used to render RSS feeds.

Copy link
Member

@yyx990803 yyx990803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous inline comment needs to be resolved

@katallaxie katallaxie closed this Oct 30, 2018
@katallaxie
Copy link
Author

Thanks for the late review. I have closed the PR, because it seems to me, that in the end the SSR in is current form is not that well suited to do these things. We are using a fork with some changes to render feeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants