Namespaced attributes #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The compiler now replaces every `:` in an attribute name to escape it `\:`. If a directive name contains an escaped colon (`\:`), it won’t be considered as a separator.
| Thanks for the PR Pierre, but I think there could be a simpler fix. |
| Great! I think there is still two changes that could be interesting though: 1/ I think there is no reason to repeat 2/ Caching [1] Benchmark: http://jsperf.com/attribute-name/ |
| Yeah these two changes make sense. If you move them into a separate PR I can merge it. |
bpierre added a commit to bpierre/vue that referenced this pull request May 15, 2014
According to the discussion in vuejs#262
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Just a suggestion for #253, don’t hesitate to close it if it does not fit your vision.
The compiler now replaces every
:in an attribute name to escape it:\:.If a directive name contains an escaped colon (
\:), it won’t be considered as a separator.