Skip to content

Conversation

@hardfist
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
The current webpack version detect logic is flaw in monorepo with webpack@4 and webpack@5, webpack expose its version by compiler.webpack.version since webpack@5.1.0(webpack/webpack#11657 webpack@5.0.0 is the only exception), other webpack plugin meets the same problem, see webpack/mini-css-extract-plugin#636

@hardfist hardfist closed this Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant