fix(types): async Component types

[mathe42]

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Build-related changes
• Other, please describe:

Does this PR introduce a breaking change? (check one)

• Yes
• No
• Not sure if this is considered a breaking change

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

• It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
• All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
• New/updated tests are included

Other information:
Look at this codeexample:

import { AsyncComponent, Component } from 'vue' const a: AsyncComponent = () => ({ component: new Promise<Component>((res, rej) => { res({}) }), }) const b: AsyncComponent = () => ({ component: () => new Promise<Component>((res, rej) => { res({}) }), })

The first example is like in the docs https://vuejs.org/v2/guide/components-dynamic-async.html#Handling-Loading-State and the second example should not work (I also looked at the implementation and I think this would not work).

The types are currently like such that the first example throws a type Error and the second throws no error. This PR fixes that.

[posva]

Can you add a test?

[mathe42]

Can you add a test?

What exactly should be tested? - As I understand the repro there are no type tests. I just found https://github.com/vuejs/vue/blob/dev/test/unit/features/component/component-async.spec.js#L322

I can add there a test that the second example doesn't work (like https://codepen.io/mathe42/pen/poNNNYx with check that 'component resolved' is not found in document)
there are tests that the first example works.

[posva]

In this case a type test case would suffice: https://github.com/vuejs/vue/tree/dev/types/test

[mathe42]

Thanks didn't saw that. Just pushed some tests (also for the simpe usages of AsyncComponent).

Not shure about my const b test. This tests that the syntax that currently is allowed (by the types) failes with this PR.

[posva]

Thanks!

[posva]

Can you leave all unrelated changes out of the PR please? I think we will handle the formatting in a different commit

[mathe42]

Yes sorry, there was more in the commits than I wanted. Working on it.

[mathe42]

@posva Removed the styling changes.

Hope this is fine now.

[mathe42]

I repleced the Vue.component tests with a single one to test if it accepts AsyncComponents...

[posva]

Thanks!