fix(slot): add a function to return the slot fallback content #10229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
slot fallback content should be evaluated only when the parent is not providing it.
posva reviewed Jul 4, 2019
posva approved these changes Jul 4, 2019
darielopper approved these changes Sep 20, 2019
| Is there a release date for this fix? Or any additional work that needs to be done? |
yyx990803 requested changes Apr 16, 2021
| } | ||
| props = extend(extend({}, bindObject), props) | ||
| } | ||
| nodes = scopedSlotFn(props) || fallback |
There was a problem hiding this comment.
We need to account for already render vnodes here (from component compiled with an older version of Vue)
| I added the commit for retro compatibility at #12014 because I couldn't push to the branch |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #10224.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: