Prevent rerender of child components that use $listeners (fix #7257) #10073
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue
Reproduction link
https://jsfiddle.net/xb4172g8/
Steps to reproduce
Open console and observe while typing something into input fields
Enter some text into name field -> Vue re-renders all three Textfield components
In line 21 replace { ...this.$listeners } with an empty object
Once again enter some text into any field -> Vue re-renders only updated Textfield
Child components that use the $listeners attribute are rerendered each time the parent component is
updated. This is due to the updateChildComponent function that sets the reactive property
vm.$listeners thus triggering a rerender of the child component.
Solution
One possible solution would be to compare the new listeners with the previous listeners. But since these are javascript functions, we cannot compare them.
It is important to note however that the listeners of the child component are updated later within the updateChildComponent function. Updating the vm.$listeners attribute should therefore not trigger any of the subscribers as the virtual DOM is eventually updated later on.
This change therefore provides a new toggleNotifyingSubscribers method that disables a reactive property's ability to notify its subscribers. We use this method to prevent the vm.$listeners property from rerendering the child component.
fix #7257
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)