Skip to content

Conversation

@zigomir
Copy link
Contributor

@zigomir zigomir commented Apr 27, 2016

Fixes #86.

Although I was thinking we might rather do this

var data = extend({}, metalsmith.metadata(), { destDirName: name })

and also update https://github.com/vuejs-templates/webpack/blob/dist/meta.json to use destDirName inside completeMessage.

@yyx990803
Copy link
Member

That makes sense - I've invited you to the templates organization so you can change both places at the same time. LGTM.

zigomir added a commit to vuejs-templates/webpack that referenced this pull request Apr 27, 2016
vuejs/vue-cli#87 - direct commit since this is not master branch
@zigomir
Copy link
Contributor Author

zigomir commented Apr 27, 2016

@yyx990803 All right, I renamed it here and in template. Now we should merge this and publish new version imo.

@yyx990803 yyx990803 merged commit 9c4e6b4 into vuejs:master Apr 27, 2016
@yyx990803
Copy link
Member

published 2.0.3.

@zigomir zigomir deleted the wrong-directory-name branch February 22, 2018 17:59
wdev733 added a commit to wdev733/vue-dashboard that referenced this pull request Aug 6, 2019
vuejs/vue-cli#87 - direct commit since this is not master branch
fullstack412 added a commit to fullstack412/Vue-dashboard that referenced this pull request Aug 16, 2019
vuejs/vue-cli#87 - direct commit since this is not master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants