Skip to content

Conversation

lvqq
Copy link
Contributor

@lvqq lvqq commented Aug 9, 2022

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
pnpm v7 makes breaking change to set strict-peer-dependencies=true by default, which may cause problems when installing.

Copy link

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix CI.

@linghengqian
Copy link

linghengqian commented Aug 26, 2022

For #6476 , #7106 , #7263 and #7284.

@lvqq
Copy link
Contributor Author

lvqq commented Aug 26, 2022

@linghengqian I will try it, but the error is not from my changes 😂

@lvqq
Copy link
Contributor Author

lvqq commented Aug 26, 2022

@linghengqian I pass the test in my local environment and I don't find any similar error from tsPluginE2e. Is there someway to rerun the failed ci checker while not pushing some new changes? I can't find any rerun button here. Thanks!

Here is my local vs remote ci:
image

image

@linghengqian
Copy link

@lvqq

  • You can checkout to your local fix-pnpm7-error branch in the IDE, merge the dev branch, then push to your remote origin branch fix-pnpm7-error, and Github Action will restart. For Jetbrains Webstorm, it can be operated directly in the graphical interface.

  • I'm not sure why your fork local build succeeded, I haven't had time to start investigating this.

@lvqq lvqq force-pushed the fix-pnpm7-error branch 3 times, most recently from c116d32 to f3531f5 Compare August 26, 2022 10:49
@lvqq lvqq force-pushed the fix-pnpm7-error branch from f3531f5 to d7baae2 Compare August 26, 2022 11:43
@lvqq
Copy link
Contributor Author

lvqq commented Aug 26, 2022

@linghengqian, I have tried several times without any changes and get it passed finally. Besides, I get different check error every time. Maybe the check CI server is not very stable and it is a matter of luck 😂

@linghengqian
Copy link

Carbon Copy @wxsms @yyx990803 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants