Skip to content

Conversation

sterashima78
Copy link

@sterashima78 sterashima78 commented Jun 19, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

Now, building webcomponents ignore filenameHashing option.
This PR make building webcomponents using filenameHashing option.
Becouse default filenameHashing option value is true, This is breaking change.

Related issue: #5438

@sterashima78 sterashima78 force-pushed the feature/use-filename-hashing-when-building-wc branch from 5babab4 to dc5ea31 Compare June 19, 2021 08:22
@sterashima78 sterashima78 marked this pull request as ready for review June 19, 2021 08:35
@sterashima78
Copy link
Author

sterashima78 commented Jun 19, 2021

CI core is failed (Segmentation fault). But in my local environment yarn test -p cli,cli-service,cli-shared-utils is passed.

@Makio64
Copy link

Makio64 commented Aug 5, 2021

Great PR, cant wait for it to be merged !

@jfuehner
Copy link

jfuehner commented Sep 8, 2021

Any update on this? Really looking forward to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants