fix publicPath reset if build in PRODUCTION mode #6259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
suyundukov reviewed Feb 4, 2021
There was a problem hiding this comment.
Linking the previous PR: #6257.
@ppossanzini you could simply change the target branch and rebase from dev, instead of creating a new PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
I have a group of microfronend applications, each one build as lib in a separate build process.
My CI/CD scripts place every build in a different server path, so i've change the publicPath in vue.config of each lib to match my publish path.
The main app load libs and use it correctly loading every lib at runtime via a json config from the correct subpath, but if a lib build has produced an additional chunk it fails if PRODUCTION env, because of publicPath has been resetted to '' and load of libs chunks happens from main app path and not from lib path; if i build in DEVELOPMENT mode it works, because in DEVELOPMENT env the cli does not reset the publicPath of lib .