Skip to content

fix config pwa.iconPaths is being ignored #6203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix config pwa.iconPaths is being ignored #6203

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb3dc9c
fix(HtmlPwaPlugin): avoid mutating input options
lkho Jan 12, 2021
c9b0620
test(pwa): add tests to check generated service worker and pwa custom…
lkho Jan 12, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(HtmlPwaPlugin): avoid mutating input options
  • Loading branch information
@lkho
lkho committed Jan 12, 2021
commit cb3dc9cb25d3dfef5e2e9fc69081352435e44fff
3 changes: 1 addition & 2 deletions packages/@vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ const defaultIconPaths = {
module.exports = class HtmlPwaPlugin {
constructor (options = {}) {
const iconPaths = Object.assign({}, defaultIconPaths, options.iconPaths)
delete options.iconPaths
this.options = Object.assign({ iconPaths: iconPaths }, defaults, options)
this.options = Object.assign({}, defaults, options, { iconPaths: iconPaths })
}

apply (compiler) {
Expand Down