Allow integrity hashes for prefetch links #5486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
haoqunjiang requested changes May 29, 2020
| tag.attributes.integrity = hash | ||
| } | ||
| } else if (tag.tagName === 'link' && tag.attributes.rel === 'stylesheet') { | ||
| } else if (tag.tagName === 'link' && (tag.attributes.rel === 'stylesheet' || tag.attributes.rel === 'prefetch')) { |
There was a problem hiding this comment.
If I'm not mistaken, the linked issue only said it's implemented for preload links, not prefetch.
And Line#49-56 needs to be removed too.
| Looks like the browsers don't actually check the integrity although setting the param works.! Tested on Chrome 81. Going to close this PR |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: