Update @vue/unit-mocha install instructions #4536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Similar to [this comment](#4294 (comment)) addressing vue-jest install issues, the install instructions for `@vue/unit-mocha` have also changed and need to be updated too. #### Before change: ```bash vue add unit-mocha 📦 Installing vue-cli-plugin-unit-mocha... npm ERR! code E404 npm ERR! 404 Not Found - GET https://registry.npmjs.org/vue-cli-plugin-unit-mocha - Not found npm ERR! 404 ``` #### After change ```bash vue add @vue/unit-mocha 📦 Installing @vue/cli-plugin-unit-mocha... + @vue/cli-plugin-unit-mocha@3.11.0 added 70 packages from 505 contributors and audited 29226 packages in 17.477s ```
There was a problem hiding this comment.
@devjack thank you for spotting this? Regarding the contributing guide could you please change the base branch to master?
| I also realised this also happens in the instructions for @vue/unit-jest installation instructions. |
haoqunjiang requested changes Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Similar to this comment addressing vue-jest install issues, the install instructions for
@vue/unit-mochahave also changed and need to be updated too.Before change:
Instructions currently read, and produce:
After change
Instructions that current work, and should read/produce:
vue add @vue/unit-mocha 📦 Installing @vue/cli-plugin-unit-mocha... + @vue/cli-plugin-unit-mocha@3.11.0 added 70 packages from 505 contributors and audited 29226 packages in 17.477sWhat kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: