chore: prefer .tsx? files over .jsx? file extensions #3909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
LinusBorg changed the title 
| @sodatea I think this is a small optimization that we can still add to v4, no? |
| Yeah I think so |
haoqunjiang approved these changes May 3, 2019
haoqunjiang changed the title haoqunjiang pushed a commit that referenced this pull request May 25, 2019
haoqunjiang added a commit that referenced this pull request May 25, 2019
This reverts commit c3b6519.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using Typescript, the webpack resolve options should prefer ts? file extensions over js? ones.
Strictly speaking, this is a breaking change, so we can ship this with v4 I think.
close #3898