Skip to content

Conversation

@posva
Copy link
Member

@posva posva commented Jan 1, 2017

No description provided.

posva added 2 commits January 1, 2017 13:53
Closes vuejs#281 Use multimatch instead of match for this purpose. The minimatch dependency has not been removed because it's still used in lib/filter.js. Filters should directly use multimatch. Once this happens, the dependency to minimatch can be removed.
@posva posva force-pushed the feature/skipInterpolation-array branch from e1efd47 to d128580 Compare January 1, 2017 13:01
@posva
Copy link
Member Author

posva commented Jan 1, 2017

@kazupon @yyx990803 I'm having some troubles with the tests locally. Something about a bin file. It's weird the pass on circleci...

lib/generate.js Outdated
return function (files, metalsmith, done) {
var keys = Object.keys(files)
var metalsmithMetadata = metalsmith.metadata()
skipInterpolation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What mean here? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad 😛 Thanks!

@yyx990803 yyx990803 merged commit c3217ee into vuejs:master Jan 2, 2017
@posva posva deleted the feature/skipInterpolation-array branch January 2, 2017 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants