Skip to content

WIP: Fix(eslint): Set parserOptions.ecmaVersion to 2017 #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

WIP: Fix(eslint): Set parserOptions.ecmaVersion to 2017 #1998

wants to merge 3 commits into from

Conversation

@LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Jul 31, 2018 •
edited
Loading

This keeps babel-eslint from complaining about newer syntax like async/await
LinusBorg added 3 commits July 31, 2018 09:21
@LinusBorg
fix(cli-plugin-eslint): set parserOptions.ecmaVersion to 2017
9a65ace 
This keeps eslint from complaining about newser syntax like async/await
@LinusBorg
test: Adjust tests for new parserOptions
d96067f
@LinusBorg
test: un-set ecmaVersion when applyTS is called
59f919e 
Otherwise tests fail when project was created with babel and typescript was added later.
@LinusBorg LinusBorg changed the title WIP:Set parserOptions.ecmaVersion to 2017 Fix(eslint): Set parserOptions.ecmaVersion to 2017 Jul 31, 2018
@yyx990803
Copy link
Member

yyx990803 commented Jul 31, 2018

Is this necessary? I've never seen it complaining about async/await.
@LinusBorg
Copy link
Member Author

LinusBorg commented Jul 31, 2018

came across it here: https://forum.vuejs.org/t/how-to-use-async-await-in-vue-cli-3/39733
@yyx990803
Copy link
Member

yyx990803 commented Jul 31, 2018

This should only be necessary if not using babel-eslint.
@LinusBorg
Copy link
Member Author

LinusBorg commented Jul 31, 2018 •
edited
Loading

Okay, you're right. Will change it so that it only applies it if we create the project without Babel and typescript.
@LinusBorg LinusBorg changed the title Fix(eslint): Set parserOptions.ecmaVersion to 2017 WIP: Fix(eslint): Set parserOptions.ecmaVersion to 2017 Aug 1, 2018
@LinusBorg LinusBorg self-assigned this Aug 1, 2018
@michalsnik
Copy link
Member

michalsnik commented Jan 2, 2019

@LinusBorg any update here? :)
@LinusBorg
Copy link
Member Author

LinusBorg commented Jan 2, 2019 •
edited
Loading

Oh, forgot about this one ^^ Will check later.

Edit: Tonight, hopefully :-P
@LinusBorg
Copy link
Member Author

LinusBorg commented Jan 26, 2019

This is too old, I'll start over
@LinusBorg LinusBorg closed this Jan 26, 2019
@LinusBorg LinusBorg deleted the LinusBorg-patch-1 branch February 26, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@LinusBorg @yyx990803 @michalsnik