WIP: fix(cli): Inform earlier in promts flow about PostCSS #1794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
CLI should inform earlier that PostCSS, Autoprefixer and CSS Modules already being supported. closes #1655
LinusBorg changed the title 
Akryum reviewed Jul 9, 2018
| name: 'CSS Pre-processors', | ||
| value: 'css-preprocessor', | ||
| description: 'Add support for CSS pre-processors like SASS, Less or Stylus', | ||
| description: 'Add support for CSS pre-processors like SASS, Less or Stylus (PostCSS is always included)', |
Member
There was a problem hiding this comment.
Note: This will only be displayed in the UI.
Member Author
There was a problem hiding this comment.
...in the UI we can go back& forth anyway, right? Then maybe we have to solve this another way.
Don't want to make the nameprop disproportionately long compared to other prompts with this ...
Contributor
There was a problem hiding this comment.
message key is used by inquirer.js for the prompts.
LinusBorg changed the title 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
CLI should inform earlier that PostCSS, Autoprefixer and CSS Modules already being supported.
closes #1655
Just a UX improvement. Without this, people might think they have to select "yes" for "Add Pre-Processor support" to get PostCSS, only to realize that they can't (and don't have to) and must start over if they don't want to select any of the pre-processors offered.