feat: Allow git commit message through UI #1541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Akryum requested changes Jun 10, 2018
| return { | ||
| folder: '', | ||
| force: false, | ||
| git: false, |
There was a problem hiding this comment.
This should be true by default to be consistent with the cli behavior.
packages/@vue/cli-ui/locales/en.json Outdated
| "label": "Additional options", | ||
| "description": "Overwrite target folder if it exists" | ||
| "description": "Overwrite target folder if it exists", | ||
| "git": "Use custom first initial commit message or skip git initialization", |
There was a problem hiding this comment.
Let's put "Initialize git repository (recommended)".
| | ||
| const cliOptions = {git: true} | ||
| // Git | ||
| if (input.skipGit) { |
There was a problem hiding this comment.
The name of the variable is wrong, it should be something like enableGit.
| // Git | ||
| if (input.skipGit) { | ||
| if (!input.gitCommit) { | ||
| cliOptions.git = 'false' |
| remote: Boolean | ||
| clone: Boolean | ||
| save: String | ||
| skipGit: Boolean! |
| input: { | ||
| folder: this.formData.folder, | ||
| force: this.formData.force, | ||
| skipGit: this.formData.git, |
| Thanks for the review! I added the requested changes. |
Akryum force-pushed the feat/commit-message branch from a8dc019 to 7e77342 Compare Akryum approved these changes Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implements #1482.
Hi! I went ahead and implemented support on UI to specify a custom initial git commit message and skip git initialization.
I'm not sure if using a single switch for both actions and skip git initialization if the switch is on but no message is specified is the best approach, I can switch to something else like having different switches if it seems a better option.