Skip to content

Ui tweaks & fixes #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 31, 2018
Merged

Ui tweaks & fixes #1409

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8dc3f4e
refactor(ui): use fetchPolic: 'cache-and-network' by default
May 30, 2018
c2a5959
feat(ui): don't display loader if cached data
May 30, 2018
ec65e57
fix(ui): eslint errors
May 30, 2018
3147187
feat(ui): new top bar design
May 30, 2018
a91e135
fix(ui): remove work icon in top bar
May 30, 2018
ce6703f
fix(ui): logger view item hover background
May 30, 2018
c6d82b1
feat(ui): Projects list show open project
May 30, 2018
af7bf10
feat(ui): top bar: responsive + no favorites message
May 30, 2018
5f34364
fix(ui): Cannot set property consoleLogLast of #<a> which has only a …
May 30, 2018
b201e50
fix(ui): loading prompts folder when installing plugin
May 31, 2018
dcaf0a6
feat(ui): help translating button + docs
May 31, 2018
7fe89d9
docs(ui): fix local. docs
May 31, 2018
4b3fbdf
fix(ui): Help translate button
May 31, 2018
dabe211
docs(ui): plugin ui dev docs improvements
May 31, 2018
e8ef0ae
docs(ui): typo
May 31, 2018
decd808
docs(ui): typo
May 31, 2018
f8b6faf
docs(ui): typo
May 31, 2018
871677c
feat(ui): auto locale now tries full code + short code
May 31, 2018
7d8eb1d
docs(ui): fix missing ref locale link
May 31, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(ui): top bar: responsive + no favorites message
  • Loading branch information
Guillaume Chau committed May 30, 2018
commit af7bf1021d0a50f6555517ef9dcc6516b1f55adc
3 changes: 3 additions & 0 deletions packages/@vue/cli-ui/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@
"scroll": "Scroll to bottom"
}
},
"top-bar": {
"no-favorites": "No favorite projects"
},
"view-badge": {
"labels": {
"tasks": {
Expand Down
10 changes: 8 additions & 2 deletions packages/@vue/cli-ui/src/components/TopBar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<template>
<div class="top-bar">
<VueDropdown
v-if="$responsive.wide"
:label="projectCurrent ? projectCurrent.name : $t('components.status-bar.project.empty')"
class="current-project"
icon-right="arrow_drop_down"
Expand All @@ -14,6 +15,8 @@
@click="openProject(project)"
/>

<div v-if="!favoriteProjects.length" class="vue-ui-empty">{{ $t('components.top-bar.no-favorites') }}</div>

<div class="dropdown-separator"/>

<VueDropdownButton
Expand Down Expand Up @@ -46,7 +49,7 @@ export default {
favoriteProjects () {
if (!this.projects) return []
return this.projects.filter(
p => p.favorite
p => p.favorite && (!this.projectCurrent || this.projectCurrent.id !== p.id)
)
}
},
Expand Down Expand Up @@ -84,6 +87,7 @@ export default {

.current-project
min-width (180px - $padding-item * 2)
margin-right ($padding-item * 2)

>>> .trigger
.vue-ui-button
Expand All @@ -92,8 +96,10 @@ export default {
width 20px
height @width

.vue-ui-empty
padding 6px

.title
font-size 22px
font-weight lighter
margin-left $padding-item
</style>
2 changes: 1 addition & 1 deletion packages/@vue/cli-ui/src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Vue.use(Responsive, {
return !this.tablet
},
wide () {
return this.width >= 1600
return this.width >= 1300
}
}
})
Expand Down