update readme for caveats of class properties #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
README.md Outdated
| } | ||
| ``` | ||
| | ||
| You can simply define a method instead of a class property in that case: |
Member
There was a problem hiding this comment.
This is not standard JavaScript pattern. It only works in Vue because the library binds it. It might be good to point this out in case readers do not know it.
Member Author
There was a problem hiding this comment.
Thanks for pointing this out. Fixed 🙂
README.md Outdated
| | ||
| ### Caveats of Class Properties | ||
| | ||
| vue-class-component corrects class properties as Vue instance data by instantiating the original constructor under the hood. While we can define instance data like native class manner, we sometimes need to know how it works. |
HerringtonDarkholme approved these changes Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As pointed out on #67, we may need to mention about caveats of class property definition. I've added it in docs on this PR.