add tsx render function example #212
Conversation
decadef20 force-pushed the tsx-render branch from 3036a79 to 7138900 Compare example/World.tsx Outdated
| } | ||
| render(h) { | ||
| return <div > | ||
| <h1>{this.title}</h1> |
There was a problem hiding this comment.
IIRC tsx requires additional type declaration under strict: true flag. Will this compile?
example/tsconfig.json Outdated
| "removeComments": true | ||
| "removeComments": true, | ||
| "jsx": "preserve", | ||
| "noImplicitAny": false |
There was a problem hiding this comment.
OK, setting noImplicitAny is a workaround. But I would still recommend to add JSXElement declaration.
HerringtonDarkholme left a comment
HerringtonDarkholme left a comment There was a problem hiding this comment.
Adding JSX related typing is documented in
http://www.typescriptlang.org/docs/handbook/jsx.html
noImplicitAny is an important guarantee for type safety so I think we should keep it on.
| Thanks for your recommendation.I have added jsx typing. Please check again. |
example/.babelrc Outdated
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "presets": [ | |||
| ["env", { | |||
There was a problem hiding this comment.
I don't think we need this preset and transform-decorators-legacy since we already transpile the code by TypeScript. Can we remove them from babelrc?
example/World.tsx Outdated
| } | ||
| render(h: CreateElement) { | ||
| return <div > | ||
| <h1>{this.title}</h1> |
There was a problem hiding this comment.
Can we simplify the render function and the component definition more? I think it could have only one simple element since we just want to show tsx is available in this component. props/methods/computed shouldn't be there since they just complicate the example, IMO.
| updated .babelrc and simplified the render function.please review it again. |
3 participants
fix #196 ,