fix: router typescript definations related to vue package #2295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-router canceled.
|
posva approved these changes Jul 9, 2024
1 task
| @posva This breaks parameter types for in-component navigation guards supplied to |
ghost mentioned this pull request 
This was referenced Aug 20, 2024
4 tasks
7 tasks
rak-phillip added a commit to rak-phillip/dashboard that referenced this pull request Jan 13, 2025
This updates the augment from `@vue/runtime core` to `vue`. See: vuejs/router#2295 Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip added a commit to rak-phillip/dashboard that referenced this pull request Jan 13, 2025
This updates the augment from `@vue/runtime core` to `vue`. See: vuejs/router#2295 Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip added a commit to rak-phillip/dashboard that referenced this pull request Jan 13, 2025
This updates the augment from `@vue/runtime core` to `vue`. See: vuejs/router#2295 Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip added a commit to rak-phillip/dashboard that referenced this pull request Jan 14, 2025
This updates the augment from `@vue/runtime core` to `vue`. See: vuejs/router#2295 Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip added a commit to rak-phillip/dashboard that referenced this pull request Jan 15, 2025
This updates the augment from `@vue/runtime core` to `vue`. See: vuejs/router#2295 Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip added a commit to rak-phillip/dashboard that referenced this pull request Jan 15, 2025
This updates the augment from `@vue/runtime core` to `vue`. See: vuejs/router#2295 Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip added a commit to rak-phillip/dashboard that referenced this pull request Jan 16, 2025
This updates the augment from `@vue/runtime core` to `vue`. See: vuejs/router#2295 Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
after
I noticed the comment :
// TODO: figure out why it cannot be 'vue' like said in docs, actullay, it works in the latest version of vue(3.4.31)