Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: check if assertion expressoin is valid lhs
  • Loading branch information
auvred committed Feb 19, 2024
commit 8ddc35bf9dead2eb22ea196405b262dbc43a8b9e
11 changes: 5 additions & 6 deletions lib/rules/valid-v-model.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,11 @@ function isOptionalChainingMemberExpression(node) {
* @returns {boolean} `true` if the node can be LHS.
*/
function isLhs(node) {
return (
node.type === 'Identifier' ||
node.type === 'MemberExpression' ||
node.type === 'TSAsExpression' ||
node.type === 'TSNonNullExpression'
)
if (node.type === 'TSAsExpression' || node.type === 'TSNonNullExpression') {
return isLhs(node.expression)
}

return node.type === 'Identifier' || node.type === 'MemberExpression'
}

/**
Expand Down
87 changes: 87 additions & 0 deletions tests/lib/rules/valid-v-model.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,33 @@ tester.run('valid-v-model', rule, {
parser: require.resolve('@typescript-eslint/parser')
}
}
},
{
filename: 'test.vue',
code: '<template><MyComponent v-model="a as unknown as string"></MyComponent></template>',
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
}
},
{
filename: 'test.vue',
code: '<template><MyComponent v-model="a!!!!"></MyComponent></template>',
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
}
},
{
filename: 'test.vue',
code: '<template><MyComponent v-model="(((a!) as unknown)! as string)!"></MyComponent></template>',
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
}
}
],
invalid: [
Expand Down Expand Up @@ -259,6 +286,66 @@ tester.run('valid-v-model', rule, {
filename: 'test.vue',
code: '<template><input v-model="(a?.b).c.d"></template>',
errors: ["'v-model' directive has potential null object property access."]
},
{
filename: 'test.vue',
code: '<template><MyComponent v-model="a() as string"></MyComponent></template>',
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
errors: [
"'v-model' directives require the attribute value which is valid as LHS."
]
},
{
filename: 'test.vue',
code: '<template><MyComponent v-model="a()!"></MyComponent></template>',
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
errors: [
"'v-model' directives require the attribute value which is valid as LHS."
]
},
{
filename: 'test.vue',
code: '<template><MyComponent v-model="a() as unknown as string"></MyComponent></template>',
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
errors: [
"'v-model' directives require the attribute value which is valid as LHS."
]
},
{
filename: 'test.vue',
code: '<template><MyComponent v-model="a()!!!!"></MyComponent></template>',
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
errors: [
"'v-model' directives require the attribute value which is valid as LHS."
]
},
{
filename: 'test.vue',
code: '<template><MyComponent v-model="(((a()!) as unknown)! as string)!"></MyComponent></template>',
languageOptions: {
parserOptions: {
parser: require.resolve('@typescript-eslint/parser')
}
},
errors: [
"'v-model' directives require the attribute value which is valid as LHS."
]
}
]
})