Skip to content

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Dec 2, 2023

try to fix #2337

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have just two minor nits, otherwise this looks good to me 🙂

@FloEdelmann FloEdelmann requested a review from ota-meshi December 4, 2023 14:45
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you! Sorry for the late review.
I didn't realize that usage was not supported 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants