feat: add allow list to no-template-shadow #2323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
FloEdelmann reviewed Nov 29, 2023
| @FloEdelmann Thanks for the suggestion! I made the change and updated the docs. Please take a look when you get the chance 🙏 |
FloEdelmann approved these changes Dec 4, 2023
docs/rules/no-template-shadow.md Outdated
| ## :wrench: Options | ||
| | ||
| Nothing. | ||
| This rule takes one option, an object, with the property `"allow"`. |
There was a problem hiding this comment.
Suggested change
| This rule takes one option, an object, with the property `"allow"`. | |
| This rule takes one optional object option, with the property `"allow"`. |
There was a problem hiding this comment.
Thanks! Done 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is an attempt at solving #2317
As suggested by @FloEdelmann, I tried to match the
no-shadowcore ESLint rule and called the optionallow.I have not modified the docs yet as I'd like to make sure the implementation is OK first.