Skip to content

Add new vue/enforce-style-attribute rule #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 9, 2024
Merged

Add new vue/enforce-style-attribute rule #2110

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d36bf2c
feat: add new `vue/enforce-style-attribute` rule (#2109)
mussinbenarbia Mar 21, 2023
e9ea5b1
Merge branch 'master' into enforce-style-attribute
FloEdelmann Jul 27, 2023
06ba377
refactor: allow multiple attributes
Nov 24, 2023
79fface
style: apply formatter
Nov 24, 2023
43a0864
docs: update documentation to reflect new implementation
Dec 3, 2023
bfde06c
Merge branch 'master' into enforce-style-attribute
mussinbenarbia Dec 3, 2023
62b053f
refactor: use sourceCode parser services instead of context
Dec 3, 2023
f1b495a
docs: move options section under rule details
Dec 3, 2023
0467dcc
docs: run docs build
Dec 4, 2023
9e5fd3a
refactor: set fixable as null and regen docs
Dec 4, 2023
43e3f63
refactor: rename allows option into allow
Dec 4, 2023
d33d671
docs: update option name in docs
Dec 4, 2023
7a1ebfb
refactor: rename rule option for better clarity
Jan 9, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: set fixable as null and regen docs
  • Loading branch information
Mussin Benarbia committed Dec 4, 2023
commit 9e5fd3aa9f3f5ba6b3bff95a55266acb46ff6f29
7 changes: 3 additions & 4 deletions docs/rules/enforce-style-attribute.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,14 @@ description: enforce or forbid the use of the `scoped` and `module` attributes i
> enforce or forbid the use of the `scoped` and `module` attributes in SFC top level style tags

- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> ***This rule has not been released yet.*** </badge>
- :wrench: The `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) can automatically fix some of the problems reported by this rule.

## :book: Rule Details

This rule allows you to selectively allow attributes on your top level style tags and warns when using an attribute that is not allowed.

### `"scoped"`

<eslint-code-block fix :rules="{'vue/enforce-style-attribute': ['error', { allows: ['scoped'] }]}">
<eslint-code-block :rules="{'vue/enforce-style-attribute': ['error', { allows: ['scoped'] }]}">

```vue
<!-- ✓ GOOD -->
Expand All @@ -35,7 +34,7 @@ This rule allows you to selectively allow attributes on your top level style tag

### `"module"`

<eslint-code-block fix :rules="{'vue/enforce-style-attribute': ['error', { allows: ['module'] }]}">
<eslint-code-block :rules="{'vue/enforce-style-attribute': ['error', { allows: ['module'] }]}">

```vue
<!-- ✓ GOOD -->
Expand All @@ -52,7 +51,7 @@ This rule allows you to selectively allow attributes on your top level style tag

### `"no-attributes"`

<eslint-code-block fix :rules="{'vue/enforce-style-attribute': ['error', { allows: ['no-attributes']}]}">
<eslint-code-block :rules="{'vue/enforce-style-attribute': ['error', { allows: ['no-attributes']}]}">

```vue
<!-- ✓ GOOD -->
Expand Down
2 changes: 1 addition & 1 deletion docs/rules/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ For example:
| [vue/define-emits-declaration](./define-emits-declaration.md) | enforce declaration style of `defineEmits` | | :hammer: |
| [vue/define-macros-order](./define-macros-order.md) | enforce order of `defineEmits` and `defineProps` compiler macros | :wrench: | :lipstick: |
| [vue/define-props-declaration](./define-props-declaration.md) | enforce declaration style of `defineProps` | | :hammer: |
| [vue/enforce-style-attribute](./enforce-style-attribute.md) | enforce or forbid the use of the `scoped` and `module` attributes in SFC top level style tags | :wrench: | :hammer: |
| [vue/enforce-style-attribute](./enforce-style-attribute.md) | enforce or forbid the use of the `scoped` and `module` attributes in SFC top level style tags | | :hammer: |
| [vue/html-button-has-type](./html-button-has-type.md) | disallow usage of button without an explicit type attribute | | :hammer: |
| [vue/html-comment-content-newline](./html-comment-content-newline.md) | enforce unified line brake in HTML comments | :wrench: | :lipstick: |
| [vue/html-comment-content-spacing](./html-comment-content-spacing.md) | enforce unified spacing in HTML comments | :wrench: | :lipstick: |
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/enforce-style-attribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ module.exports = {
categories: undefined,
url: 'https://eslint.vuejs.org/rules/enforce-style-attribute.html'
},
fixable: 'code',
fixable: null,
schema: [
{
type: 'object',
Expand Down