Skip to content

Add padding-lines-in-component-definition rule #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 11, 2023
Merged

Add padding-lines-in-component-definition rule #2052

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
caec13d
feat: add padding-lines-in-component-definition rule
ItMaga Dec 1, 2022
b34bf66
refactor: rename check to verify
ItMaga Dec 1, 2022
23354ca
fix: add withinOption guard in define*
ItMaga Jan 7, 2023
02dbdbe
feat: add non-property nodes support
ItMaga Jan 7, 2023
3d00c8d
fix: use eslint-utils
ItMaga Jan 10, 2023
11a6d89
chore: clean up code
ItMaga Jan 11, 2023
e527cdb
Merge branch 'master' into padding-lines-in-component-definition
FloEdelmann Jan 11, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use eslint-utils
  • Loading branch information
@ItMaga
ItMaga committed Jan 10, 2023
commit 3d00c8d232c36d45e3dc7b0513a61cd05485918f
4 changes: 2 additions & 2 deletions lib/rules/padding-lines-in-component-definition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*/

const utils = require('../utils')
const { isComment } = require('../utils/indent-utils')
const { isCommentToken } = require('eslint-utils')

const AvailablePaddingOptions = {
Never: 'never',
Expand Down Expand Up @@ -223,7 +223,7 @@ module.exports = {
const tokenBeforeNext = sourceCode.getTokenBefore(nextProperty, {
includeComments: true
})
const isCommentBefore = isComment(tokenBeforeNext)
const isCommentBefore = isCommentToken(tokenBeforeNext)
const reportNode = isCommentBefore ? tokenBeforeNext : nextProperty

const betweenLinesRange =
Expand Down