Skip to content

Ignore well known tags in component-name-in-template-casing #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Ignore well known tags in component-name-in-template-casing #2031

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a95c15d
Fix false positives for well known tags in `component-name-in-templat…
Kaciras Nov 6, 2022
0254951
Merge branch 'master' into master
Kaciras Nov 20, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions lib/rules/component-name-in-template-casing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,23 +90,21 @@ module.exports = {
return false
}

if (
(!utils.isHtmlElementNode(node) && !utils.isSvgElementNode(node)) ||
utils.isHtmlWellKnownElementName(node.rawName) ||
utils.isSvgWellKnownElementName(node.rawName)
) {
return false
}

if (!registeredComponentsOnly) {
// If the user specifies registeredComponentsOnly as false, it checks all component tags.
if (
(!utils.isHtmlElementNode(node) && !utils.isSvgElementNode(node)) ||
utils.isHtmlWellKnownElementName(node.rawName) ||
utils.isSvgWellKnownElementName(node.rawName)
) {
return false
}
return true
}
// We only verify the registered components.
if (registeredComponents.has(casing.pascalCase(node.rawName))) {
return true
}

return false
// We only verify the registered components.
return registeredComponents.has(casing.pascalCase(node.rawName))
}

let hasInvalidEOF = false
Expand Down
9 changes: 9 additions & 0 deletions tests/lib/rules/component-name-in-template-casing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,15 @@ tester.run('component-name-in-template-casing', rule, {
`
},

{
code: `
<template><div/></template>
<script setup>const Div = 0</script>
`,
options: ['PascalCase'],
filename: 'test.vue'
},

// globals
{
code: `
Expand Down