v-model: Clarify IME caveat tip #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously, the tip on using `input` to listen to IME-based composition input was unclear. In the context of the preceding statement about `textarea` and `input type=text` elements using `input`, it seemed that composition with v-model should work with those inputs. This change makes it clear that `v-model` should be replaced with a custom `@input/:value` pair.
skirtles-code approved these changes Jan 12, 2021
jlewallen added a commit to fieldkit/cloud that referenced this pull request May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of Problem
The tip on using
inputto listen to IME-based composition input was unclear. In the context of the preceding statement abouttextareaandinput type=textelements usinginput, it seemed that composition with v-model should work with those inputs.Proposed Solution
This change makes it clear that
v-modelshould be replaced with a custom@input/:valuepair.Additional Information
See this comment where @yyx990803 mentions this solution.
See also this pull request to add a
.eagerfeature that would simplify this.