Skip to content

fix(playwright): use npm run to start the server on default port #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix(playwright): use npm run to start the server on default port #540

merged 2 commits into from
Jul 10, 2024

Conversation

zetaraku
Copy link
Contributor

@zetaraku zetaraku commented Jul 4, 2024

Description

When running Playwright end-to-end testing from Playwright Test for VSCode, an error is thrown:

Error: Process from config.webServer was not able to start. Exit code: 1

This is probably because the extension runs without adding node_modules/.bin to PATH like npm run does.

What this PR does

This PR uses npm run to start the server and adjusts the port according to the default port of vite dev or vite preview.
cexbrayat
cexbrayat approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!
@cexbrayat cexbrayat merged commit cf3f7a7 into vuejs:main Jul 10, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@zetaraku @cexbrayat