Skip to content

fix: specify the sub-project to type-check #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2023
Merged

fix: specify the sub-project to type-check #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: specify the sub-project to type-check 
Fixes #267 It's because I moved the `compilerOptions` from `tsconfig.json` to `tsconfig.app.json` in the 2023-05-05 (v3.6.2) release, but forgot to change the `type-check` script. This isn't comprehensive because it doesn't check all the sub-projects, but at least it's the same scope as previous versions. Ideally I hope #274 can work reliably. But now I'm not sure. So let's first fix this bug.
  • Loading branch information
@haoqunjiang
haoqunjiang committed May 12, 2023
commit eb8ad5d74aa62c2b8ff7046c6391f08db8e25a35
2 changes: 1 addition & 1 deletion template/config/typescript/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"scripts": {
"build": "run-p type-check build-only",
"build-only": "vite build",
"type-check": "vue-tsc --noEmit"
"type-check": "vue-tsc --noEmit -p tsconfig.app.json --composite false"
},
"devDependencies": {
"@types/node": "^18.16.3",
Expand Down